CI: include answer-progress Playwright journey in production UI gate by BigSimmo · Pull Request #793 · BigSimmo/Database

BigSimmo · 2026-07-17T20:36:35Z

Summary

Adds the tests/answer-progress-ui-smoke.spec.ts spec to Playwright selection in playwright.config.ts so the production UI gate covers answer-progress safety assertions.
Updates scripts/ci-change-scope.mjs to classify edits to that spec as UI-affecting, closing a verification gap where assertion edits could slip past the required Chromium UI job.
Supersedes CI: include answer-progress Playwright journey in production UI gate #748 (original blocked on PR policy metadata).

Verification

node scripts/ci-change-scope.mjs --self-test passed.
node scripts/ci-change-scope.mjs --json --files tests/answer-progress-ui-smoke.spec.ts reports ui_changed: true.
UI verification not run: hosted CI Production UI gate required to fully validate the Playwright journey in this babysit pass.

Risk and rollout

Risk: low; change is limited to test and CI-classifier configuration — no runtime application behavior is altered.
Rollback: revert this PR; the answer-progress spec returns to the pre-CI-selection state.
Provider or production effects: None

Summary by CodeRabbit

Bug Fixes
- Improved automated test selection so answer-progress and additional UI smoke tests are included in production verification.
- Updated change detection to correctly identify answer-progress UI test changes and trigger the appropriate validation coverage.
Documentation
- Added a review record documenting CI verification limitations related to unavailable external font downloads.

…ation-system-in-bigsimmo

supabase · 2026-07-17T20:36:40Z

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

coderabbitai · 2026-07-17T20:36:54Z

📝 Walkthrough

Walkthrough

Playwright production test matching now includes the answer-progress and additional UI tool specs. CI scope detection and self-tests classify the answer-progress smoke test as UI, source, and coverage scope, with the verification outcome recorded in the review ledger.

Changes

Production UI coverage

Layer / File(s)	Summary
Expand production Playwright selection `playwright.config.ts`	Production and top-level Playwright matching now include `answer-progress-ui-smoke`, `tools-collapse`, and `tools-task-directory`.
Align CI scope classification `scripts/ci-change-scope.mjs`, `docs/branch-review-ledger.md`	The classifier allowlist and self-test recognize the answer-progress smoke test as source, coverage, and UI scope, and the verification result is recorded in the ledger.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

BigSimmo/Database#454: Introduced related CI change-scope classification and downstream gating logic.
BigSimmo/Database#592: Updated Playwright production test-selection patterns for UI spec variants.
BigSimmo/Database#748: Overlaps on production UI gating, classifier updates, and review-ledger records.

Suggested labels: codex

Suggested reviewers: claude

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: expanding the production UI gate to include the answer-progress Playwright journey.
Description check	✅ Passed	The description covers Summary, Verification, and Risk and rollout, and the missing optional sections do not block understanding.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch cursor/answer-progress-playwright-db17

⚔️ Resolve merge conflicts

Resolve merge conflict in branch cursor/answer-progress-playwright-db17

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@playwright.config.ts`:
- Around line 15-16: Update productionSpecPattern in the Playwright
configuration to include the ui-tools-collapse and ui-tools-task-directory spec
alternatives, keeping it aligned with testMatch and the production UI gate
scope.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c2ee264-5361-4dd8-8ef8-397df0550f13

📥 Commits

Reviewing files that changed from the base of the PR and between 3fe441a and ac7098e.

📒 Files selected for processing (3)

docs/branch-review-ledger.md
playwright.config.ts
scripts/ci-change-scope.mjs

coderabbitai · 2026-07-17T20:39:13Z

+  /.*(?:answer-progress-ui-smoke|ui-(smoke|stress|accessibility|tools|overlap|universal-search|specifiers|formulation|pwa))\.spec\.ts/;
 const mockupSpecPattern = /.*ui-(tools|tools-collapse|tools-task-directory)\.spec\.ts/;


🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Keep the production matcher aligned with testMatch.

Line 15 still omits ui-tools-collapse and ui-tools-task-directory, although Line 22 and the PR objective include both. If the Chromium production project uses productionSpecPattern, those specs will remain excluded from the production UI gate. Add both alternatives here or explicitly remove them from the production-scope objective.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@playwright.config.ts` around lines 15 - 16, Update productionSpecPattern in the Playwright configuration to include the ui-tools-collapse and ui-tools-task-directory spec alternatives, keeping it aligned with testMatch and the production UI gate scope.

…s-playwright-db17

github-actions · 2026-07-17T21:10:23Z

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

Production UI — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #3107 (cancelled).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

BigSimmo and others added 3 commits July 18, 2026 03:26

test: run answer progress journey in CI

a1ed3b9

Merge origin/main to resolve PR conflicts

1aca4a7

Merge remote-tracking branch 'origin/main' into codex/improve-verific…

ac7098e

…ation-system-in-bigsimmo

cursor Bot enabled auto-merge (squash) July 17, 2026 20:36

merge: resolve branch-review-ledger conflict with main

aea7c30

coderabbitai Bot reviewed Jul 17, 2026

View reviewed changes

cursoragent added 3 commits July 17, 2026 20:46

Merge remote-tracking branch 'origin/main' into cursor/answer-progres…

bb09a6b

…s-playwright-db17

Merge remote-tracking branch 'origin/main' into cursor/answer-progres…

6563910

…s-playwright-db17

Merge remote-tracking branch 'origin/main' into cursor/answer-progres…

53206d8

…s-playwright-db17

BigSimmo mentioned this pull request Jul 18, 2026

fix: land unique open-PR queue onto current main #808

Merged

11 tasks

BigSimmo closed this Jul 18, 2026

auto-merge was automatically disabled July 18, 2026 06:22
Pull request was closed

This was referenced Jul 18, 2026

fix: finish screenshot-PR residuals (Also matches order + error focus) #812

Merged

fix: stop Escape focus restore from closing the app-mode menu #822

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: include answer-progress Playwright journey in production UI gate#793

CI: include answer-progress Playwright journey in production UI gate#793
BigSimmo wants to merge 7 commits into
mainfrom
cursor/answer-progress-playwright-db17

BigSimmo commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

supabase Bot commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		/.*(?:answer-progress-ui-smoke\|ui-(smoke\|stress\|accessibility\|tools\|overlap\|universal-search\|specifiers\|formulation\|pwa))\.spec\.ts/;
		const mockupSpecPattern = /.*ui-(tools\|tools-collapse\|tools-task-directory)\.spec\.ts/;

Conversation

BigSimmo commented Jul 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Risk and rollout

Summary by CodeRabbit

Uh oh!

supabase Bot commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 17, 2026

CI triage

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BigSimmo commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading